Skip to content

fix: jsonc parsing in the IDE2 backend #1948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 13, 2023
Merged

fix: jsonc parsing in the IDE2 backend #1948

merged 1 commit into from
Mar 13, 2023

Conversation

@kittaakos
Copy link
Contributor

Motivation

Relaxed the settings.json parsing in the IDE2's backend. The problem occurred when the settings.json contained comments or a trailing comma.

Change description

Use jsonc-parser and allow comments, a trailing comma, and empty content.

Other information

Reviewer checklist

Closes #1945

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

@kittaakos kittaakos added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Mar 10, 2023
@kittaakos kittaakos self-assigned this Mar 10, 2023
@kittaakos kittaakos requested review from AlbyIanna and per1234 March 10, 2023 13:22
AlbyIanna
AlbyIanna reviewed Mar 10, 2023
View reviewed changes
fix: jsonc parsing in the IDE2 backend
309a82b 
Occurred when `settings.json` contained comments or a trailing comma.

Closes #1945

Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
AlbyIanna
AlbyIanna approved these changes Mar 10, 2023
View reviewed changes
Copy link
Contributor

@AlbyIanna AlbyIanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM 👍

@kittaakos kittaakos merged commit fb10de1 into main Mar 13, 2023
@kittaakos kittaakos deleted the #1945 branch March 13, 2023 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@per1234 per1234 per1234 approved these changes

+1 more reviewer

@AlbyIanna AlbyIanna AlbyIanna approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@kittaakos kittaakos

Labels

topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

settings.json parsing fails on the IDE2 backend if settings.json has comments

3 participants

@kittaakos @AlbyIanna @per1234