fix: show notification if lib/core install failed #2061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #621 Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
kittaakos
added
topic: code
This was referenced May 11, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
IDE2 should notify the user when installing a library/platform has failed.
Change description
For the verification, please follow #621.
621.mp4
This PR should also cover platform install failures. For example, nothing happens when there is no Internet connection and one tries to install a platform with
2.1.0. This PR should cover it. Providing a less cryptic error message with no Internet connection is separate from this PR: #1429.2.1.0:621_no_notfication_if_platform_install_failed.mp4
Build from this PR:
621_platform_no_internet.mp4
Other information
Closes #621
Reviewer checklist