-
-
Notifications
You must be signed in to change notification settings - Fork 443
[ATL-960] Disable editor quick suggestion #221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
d001002
to
50c98be
Compare
50c98be
to
ba2834b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is exactly what we needed :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks to me; thank you for the patch!
Please use single-quoted strings in the future. If it's hard to track, we need to enforce it with a linter rule. Thanks!
@kittaakos are you ok adding |
Just add a linter rule now. Thanks! |
0b471f3
to
876b387
Compare
arduino-ide-extension/tslint.json
Outdated
@@ -15,6 +15,7 @@ | |||
"check-else", | |||
"check-whitespace" | |||
], | |||
"quotemark": [true, "single", "avoid-escape"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We used to use this rule in Theia:
"quotemark": {
"options": [
true,
"single",
"jsx-single",
"avoid-escape",
"avoid-template"
]
},
👆 This will be obsolete once we switch to @typescript-eslint/eslint-plugin
.
876b387
to
5532f11
Compare
The code looks good. Thank you for the updates, @fstasi 👍 |
While the auto complete functionality will be extremely useful to advanced users, the low level code it exposes constantly while typing will be confusing and distracting to beginners.
This PR disables by default the editor quick suggestion, adding a checkbox in the arduino preference panel to enable it.
Jira Task
Github Issue: fixes #17