Skip to content

[ATL-960] Disable editor quick suggestion #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 17, 2021
Merged

Conversation

fstasi
Copy link
Contributor

@fstasi fstasi commented Mar 15, 2021

While the auto complete functionality will be extremely useful to advanced users, the low level code it exposes constantly while typing will be confusing and distracting to beginners.

This PR disables by default the editor quick suggestion, adding a checkbox in the arduino preference panel to enable it.

Jira Task
Github Issue: fixes #17

@fstasi fstasi requested a review from kittaakos March 15, 2021 08:33
@fstasi fstasi force-pushed the atl-960--quicksuggestion branch from d001002 to 50c98be Compare March 15, 2021 11:32
@fstasi fstasi marked this pull request as ready for review March 15, 2021 11:33
@fstasi fstasi force-pushed the atl-960--quicksuggestion branch from 50c98be to ba2834b Compare March 16, 2021 14:14
Copy link

@ubidefeo ubidefeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is exactly what we needed :)

Copy link
Contributor

@kittaakos kittaakos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks to me; thank you for the patch!

Please use single-quoted strings in the future. If it's hard to track, we need to enforce it with a linter rule. Thanks!

@fstasi
Copy link
Contributor Author

fstasi commented Mar 17, 2021

The code looks to me; thank you for the patch!

Please use single-quoted strings in the future. If it's hard to track, we need to enforce it with a linter rule. Thanks!

@kittaakos are you ok adding prettier? I saw it's used already in the theia repo

@kittaakos
Copy link
Contributor

@kittaakos are you ok adding prettier? I saw it's used already in the theia repo

Just add a linter rule now. Thanks!

@fstasi fstasi force-pushed the atl-960--quicksuggestion branch 4 times, most recently from 0b471f3 to 876b387 Compare March 17, 2021 10:30
@@ -15,6 +15,7 @@
"check-else",
"check-whitespace"
],
"quotemark": [true, "single", "avoid-escape"],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We used to use this rule in Theia:

    "quotemark": {
      "options": [
        true,
        "single",
        "jsx-single",
        "avoid-escape",
        "avoid-template"
      ]
    },

👆 This will be obsolete once we switch to @typescript-eslint/eslint-plugin.

@fstasi fstasi force-pushed the atl-960--quicksuggestion branch from 876b387 to 5532f11 Compare March 17, 2021 10:37
@kittaakos
Copy link
Contributor

The code looks good. Thank you for the updates, @fstasi 👍

@fstasi fstasi merged commit 6dadd17 into main Mar 17, 2021
@fstasi fstasi deleted the atl-960--quicksuggestion branch March 17, 2021 16:50
@per1234 per1234 added topic: code Related to content of the project itself type: enhancement Proposed improvement labels Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable editor.quickSuggestions setting by default
4 participants