Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give build workflow step access to required deployment environment #2672

Merged
merged 2 commits into from
Apr 1, 2025
Merged

Give build workflow step access to required deployment environment #2672

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
875b42b
Trim trailing whitespace in build workflow
per1234 Mar 31, 2025
345dd7b
Give build workflow step access to required deployment environment
per1234 Mar 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,6 +172,7 @@ jobs:
is-nightly: ${{ steps.determination.outputs.is-nightly }}
channel-name: ${{ steps.determination.outputs.channel-name }}
publish-to-s3: ${{ steps.determination.outputs.publish-to-s3 }}
environment: production
permissions: {}
steps:
- name: Determine the type of build
Expand Down Expand Up @@ -589,7 +590,7 @@ jobs:

permissions:
id-token: write
contents: read
contents: read

steps:
- name: Download all job transfer artifacts
Expand All @@ -602,8 +603,8 @@ jobs:
- name: Configure AWS Credentials for Nightly [S3]
uses: aws-actions/configure-aws-credentials@v4
with:
role-to-assume: ${{ secrets.AWS_ROLE_ARN }}
aws-region: us-east-1
role-to-assume: ${{ secrets.AWS_ROLE_ARN }}
aws-region: us-east-1

- name: Publish Nightly [S3]
run: |
Expand Down Expand Up @@ -661,8 +662,8 @@ jobs:
if: needs.build-type-determination.outputs.publish-to-s3 == 'true'
uses: aws-actions/configure-aws-credentials@v4
with:
role-to-assume: ${{ secrets.AWS_ROLE_ARN }}
aws-region: us-east-1
role-to-assume: ${{ secrets.AWS_ROLE_ARN }}
aws-region: us-east-1

- name: Publish Release [S3]
if: needs.build-type-determination.outputs.publish-to-s3 == 'true'
Expand Down
Loading