Footer min-height for library and board manager #392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Increase the `min-height` from 26px to 30px to prevent the list items from changing height when mousing over them
|
|
|
I have verified the changes locally on macOS. It works as described. Thank you for the patch 👍 +1 for merging it. |
per1234
added
topic: code
|
Is there any chance of this being merged? I've just installed beta 10 and this issue hasn't been fixed by any other changes. It's quite jarring - I'm autistic and the jump feels painful (which was my motivation for finding a fix in the first place!) |
AlbyIanna
approved these changes
Oct 7, 2021
There was a problem hiding this comment.
Hi @IrregularShed, this works for me! ✅
Thank you so much for contributing and sorry for the big delay in approving this PR! 🙏
rsora
added
criticality: medium
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows 10 (and possibly others), rolling over the items in the Library Manager and Boards Manager causes an unpleasant jump, as seen here:
This PR increases the
min-heightof the footer for the list items from 26px to 30px, which is the minimum value required to prevent this from occurring, and improves the UX in doing so, without changing the spacing excessively: