Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve remote sketchbook tree #459

Merged
merged 3 commits into from
Jul 22, 2021
Merged

Improve remote sketchbook tree #459

merged 3 commits into from
Jul 22, 2021

Conversation

fstasi
Copy link
Contributor

@fstasi fstasi commented Jul 20, 2021

Why

A major re-design of the sketchbook tree is needed in order to enable a number of features.

What to expect

  • improved performances when refreshing the sketch tree. Resources are now loaded on demand meaning you will notice a short delay when opening a directory for the first time. A caching system is in place in order to make subsequent actions more quick
  • The sketchbook tree highlights the file currently marked as "active" in the editor. The containing folders are automatically expanded if closed, in order to help the users immediately see the location of the files they are working on
  • Creating a file in the local file system automatically adds it to the sketchbook tree and make it selectable. This is required in order to allow creation/removal/rename of files in the "local copy" of a remote sketchbook
  • overall performance improvements: mapping between remote sketches and local files is done once, as soon as the cache is generated. This ensures less access to the fileSystem and hence a snappier experience of the feature

@fstasi fstasi force-pushed the improve-remote-sketch-tree branch from 2b4ac21 to cb71ce7 Compare July 21, 2021 13:49
Copy link
Contributor

@AlbyIanna AlbyIanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fstasi fstasi force-pushed the improve-remote-sketch-tree branch from 0e5d1ee to 924e4c7 Compare July 22, 2021 10:47
@fstasi fstasi force-pushed the improve-remote-sketch-tree branch from 924e4c7 to 65b079b Compare July 22, 2021 11:02
@fstasi fstasi merged commit d790266 into main Jul 22, 2021
@fstasi fstasi deleted the improve-remote-sketch-tree branch July 22, 2021 12:34
@per1234 per1234 added the topic: code Related to content of the project itself label Oct 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants