Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Theia 18 hotfixes #528

Merged
merged 4 commits into from
Oct 6, 2021
Merged

Theia 18 hotfixes #528

merged 4 commits into from
Oct 6, 2021

Conversation

fstasi
Copy link
Contributor

@fstasi fstasi commented Oct 6, 2021

What

  • monaco suggestions are now correctly highlighted
  • re-enabled editor tabs rename/delete
  • avoid duplication of monaco tabs removing legacy ones (without the counter flag)

@fstasi fstasi requested a review from AlbyIanna October 6, 2021 15:00
AlbyIanna
AlbyIanna approved these changes Oct 6, 2021
View reviewed changes
Copy link
Contributor

@AlbyIanna AlbyIanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌶️

@AlbyIanna AlbyIanna merged commit 846c22c into main Oct 6, 2021
@AlbyIanna AlbyIanna deleted the theia-18-hotfixes branch October 6, 2021 15:50
@per1234 per1234 added topic: code Related to content of the project itself topic: theia Related to the Theia IDE framework type: imperfection Perceived defect in any part of project labels Oct 20, 2021
@per1234 per1234 mentioned this pull request Oct 27, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlbyIanna AlbyIanna AlbyIanna approved these changes

Assignees

@ubidefeo ubidefeo

Labels
topic: code Related to content of the project itself topic: theia Related to the Theia IDE framework type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fstasi @AlbyIanna @ubidefeo @per1234