Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gRPC user agent #834

Merged
merged 1 commit into from
Feb 14, 2022
Merged

Add gRPC user agent #834

merged 1 commit into from
Feb 14, 2022

Conversation

silvanocerza
Copy link
Contributor

@silvanocerza silvanocerza commented Feb 14, 2022

This PR adds the arduino-ide/<version> User Agent as the primary UA when connecting to the CLI gRPC daemon.

Closes #790.

@silvanocerza silvanocerza added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Feb 14, 2022
@silvanocerza silvanocerza self-assigned this Feb 14, 2022
@silvanocerza silvanocerza merged commit 5ab3a74 into main Feb 14, 2022
@silvanocerza silvanocerza deleted the scerza/user-agent branch February 14, 2022 11:39
AlbyIanna pushed a commit that referenced this pull request Feb 15, 2022
AlbyIanna pushed a commit that referenced this pull request Feb 15, 2022
* Remove check for updates on startup setting

* Remove useless exported function

* Update template-package.json used to package IDE

* Add function to get channel file during packaging step

* Add updates check

* move ide updater on backend

* configure updater options

* add auto update preferences

* TMP check updates on start and download

* index on check-update-startup: fcb8f6e TMP check updates on start and download

* set version to skip on local storage

* add IDE setting to toggle update check on start-up

* comment out check for updates on startup and auto update settings

* Update Theia to 1.22.1

* updated CI

* download changelog and show it in IDE updater dialog

* remove useless file

* remove useless code

* add i18n to updater dialog

* fix i18n

* refactor UpdateInfo typing

* add macos zip to artifacts

* Simply use `--ignore-engines`

* Use correct --ignore-engines

* Fix semver#valid call

* Use C++17

* updated documentation

* add update channel preference

* update updater url

* updated documentation

* Fix the C++ version

* Build flag for cpp

* add disclaimer with correct node version

* Update `electron-builder`

* Fix `Electron.Menu` issue

* Skip electron rebuild

* Rebuild native dependencies beforehand

* Use resolutions section

* Update template-package.json as well

* move ide-updater to electron application

* refactor ide-updater service

* update yarn.lock

* update i18n

* Revert "Add gRPC user agent (#834)"

This reverts commit 5ab3a74.

* fix ide download url

* update latest file in CI

* fix i18n check

Co-authored-by: Silvano Cerza <silvanocerza@gmail.com>
Co-authored-by: Francesco Stasi <f.stasi@me.com>
Co-authored-by: Mark Sujew <msujew@yahoo.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add user-agent property to gRPC client
2 participants