Automatically check for updates only once #863
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlbyIanna
force-pushed
the
fix-multiple-updater-checks
branch
from
be77ad5 to
e5789b6
Compare
AlbyIanna
force-pushed
the
fix-multiple-updater-checks
branch
from
753d057 to
489d4a8
Compare
fstasi
approved these changes
Feb 24, 2022
per1234
added
topic: code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Checking for updates should happen only once at startup.
Right now, every time a new sketch is open (that is, every time an electron renderer process is instantiated) a check for updates is performed. Since we don't want to flood the users with unnecessary dialogs, we need to show it only on the first sketch they open.
Change description
Add a flag to check if an initial check has already been performed
Reviewer checklist