Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Override the RELOAD_REQUESTED_SIGNAL correctly #880

Merged
merged 1 commit into from
Mar 3, 2022
Merged

Override the RELOAD_REQUESTED_SIGNAL correctly #880

merged 1 commit into from
Mar 3, 2022

Conversation

msujew
Copy link
Contributor

@msujew msujew commented Mar 3, 2022

Closes #829

The original Theia code contains a new IPC signal RELOAD_REQUESTED_SIGNAL, which wasn't used in the Arduino IDE.

@per1234 per1234 added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Mar 3, 2022
AlbyIanna
AlbyIanna approved these changes Mar 3, 2022
View reviewed changes
Copy link
Contributor

@AlbyIanna AlbyIanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlbyIanna AlbyIanna merged commit e6b9d4e into main Mar 3, 2022
@AlbyIanna AlbyIanna deleted the msujew/fix-save-as branch March 3, 2022 14:37
This was referenced Mar 10, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlbyIanna AlbyIanna AlbyIanna approved these changes

Assignees
No one assigned
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Saved sketch is not opened after "Save As" operation
3 participants
@msujew @AlbyIanna @per1234