Skip to content

Add privacy policy menu item #883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 9, 2022
Merged

Add privacy policy menu item #883

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion arduino-ide-extension/src/browser/contributions/help.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,10 @@ export class Help extends Contribution {
Help.Commands.VISIT_ARDUINO,
createOpenHandler('https://www.arduino.cc/')
);
registry.registerCommand(
Help.Commands.PRIVACY_POLICY,
createOpenHandler('https://www.arduino.cc/en/privacy-policy')
);
}

registerMenus(registry: MenuModelRegistry): void {
Expand Down Expand Up @@ -117,9 +121,13 @@ export class Help extends Contribution {
order: '6',
});
registry.registerMenuAction(ArduinoMenus.HELP__FIND_GROUP, {
commandId: IDEUpdaterCommands.CHECK_FOR_UPDATES.id,
commandId: Help.Commands.PRIVACY_POLICY.id,
order: '7',
});
registry.registerMenuAction(ArduinoMenus.HELP__FIND_GROUP, {
commandId: IDEUpdaterCommands.CHECK_FOR_UPDATES.id,
order: '8',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest switching places between the Help > Privacy Policy and Help > Check for Arduino IDE updates menu items.

It seems more logical to me to have all the website visit menu items grouped together, rather than having the very different Check for Arduino IDE updates menu item interspersed.

Before:

  • Help
    • Getting Started
    • Environment
    • Troubleshooting
    • Reference
    • Find in Reference
    • Frequently Asked Questions
    • Visit Arduino.cc
    • Check for Arduino IDE Updates
    • Privacy Policy
    • About Arduino IDE
    • Toggle Developer Tools

After:

  • Help
    • Getting Started
    • Environment
    • Troubleshooting
    • Reference
    • Find in Reference
    • Frequently Asked Questions
    • Visit Arduino.cc
    • Privacy Policy
    • Check for Arduino IDE Updates
    • About Arduino IDE
    • Toggle Developer Tools

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the URL be an internationalized string (nls.localize('https://www.arduino.cc/en/privacy-policy')) so that it can be pointed at the appropriate page (e.g., https://www.arduino.cc/it/privacy-policy)?

I tried changing my browser locale to it in order to see whether arduino.cc automatically redirects https://www.arduino.cc/en/privacy-policy to https://www.arduino.cc/it/privacy-policy, and it didn't, but I don't know much about the subject.

@per1234 I thought about that too, but seeing the page was in English-only I didn't localize the URL. @ubidefeo, do you think we should ask someone to translate that page?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AlbyIanna there is an Italian language version of the page:

https://www.arduino.cc/it/privacy-policy

I don't think there are any others at the moment.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I swear it didn't work the first time I tried that URL 😅 It just redirected me to the English version of the page. Weird.

Anyway, should we localize it? I don't know, I think it'd be kinda strange if we'd localize it only for Italian folks.

Copy link
Contributor

@per1234 per1234 Mar 8, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't personally find it strange, but I also don't have strong feelings about the subject either way. I added the question about the internationalization only as a comment, and not as part of my review for that reason.

I'll go ahead and submit an approving review now since the review suggestion I made has been resolved (thanks!) and we are on the same page regarding the existence of an Italian version of the page.

I'll leave the decision on whether to internationalize that URL string to you or any other interested parties.

});
}

registerKeybindings(registry: KeybindingRegistry): void {
Expand Down Expand Up @@ -167,5 +175,10 @@ export namespace Help {
label: nls.localize('arduino/help/visit', 'Visit Arduino.cc'),
category: 'Arduino',
};
export const PRIVACY_POLICY: Command = {
id: 'arduino-privacy-policy',
label: nls.localize('arduino/help/privacyPolicy', 'Privacy Policy'),
category: 'Arduino',
};
}
}
3 changes: 2 additions & 1 deletion i18n/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,8 @@
"reference": "Reference",
"findInReference": "Find in Reference",
"faq": "Frequently Asked Questions",
"visit": "Visit Arduino.cc"
"visit": "Visit Arduino.cc",
"privacyPolicy": "Privacy Policy"
},
"certificate": {
"uploadRootCertificates": "Upload SSL Root Certificates",
Expand Down