Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install oktokit in changelog workflow #901

Merged
merged 2 commits into from
Mar 14, 2022
Merged

Install oktokit in changelog workflow #901

merged 2 commits into from
Mar 14, 2022

Conversation

AlbyIanna
Copy link
Contributor

@AlbyIanna AlbyIanna commented Mar 10, 2022 •
edited
Loading

Motivation

The changelog in the update dialog is not displayed correctly.

Change description

  • Workflow to compose changelog is failing because octokit is not installed, so we just install it
  • Fix the string that searches for the current version in the changelog

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

@AlbyIanna AlbyIanna requested a review from fstasi March 10, 2022 14:59
@per1234 per1234 added topic: infrastructure Related to project infrastructure type: imperfection Perceived defect in any part of project labels Mar 10, 2022
@AlbyIanna AlbyIanna merged commit 61c2b1a into main Mar 14, 2022
@AlbyIanna AlbyIanna deleted the fix-changelog branch March 14, 2022 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fstasi fstasi fstasi approved these changes

Assignees
No one assigned
Labels
topic: infrastructure Related to project infrastructure type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlbyIanna @fstasi @per1234