#919, #881: Fixed 3rd party URLs-related issues

[kittaakos]

Motivation

This PR fixes various 3rd party URLs issues:

• fixes a problem when parsing an empty/blank string into 3rd part URLs array (Empty additional boards URLs input generates incorrect board_manager#additional_urls entry in the CLI config #919),
• the height of the 3rd party URLs textarea height (Incorrect "Additional Boards Manager URLs" dialog field height #881)

Change description

• Single-sourced and fixed the way we parse a string to 3rd party URLs, added tests.
• Adjusted the style of the dialog content display to fix the textarea height in the 3rd party URLs selector dialog.

Before:

After:

Other information

I am happy to split the PR into two, however, I thought it's easier to verify the 3rd party URLs changes in one shot. Let me know if a PR split is desired.

[ ] Docs have been added / updated (for bug fixes / features)

I do not know what this means. Thanks!

Reviewer checklist

• PR addresses a single concern. (no, I can open a follow-up with Incorrect "Additional Boards Manager URLs" dialog field height #881 only, if required)
• The PR has no duplicates (please search among the Pull Requests before creating one)
• PR title and description are properly filled.
• Docs have been added / updated (for bug fixes / features)

[fstasi]

lgtm

[fstasi]

Thanks @kittaakos for contributing, works like a charm to me.
@per1234 do you want to give this PR a try?

[per1234]

The File > Preferences > Additional Boards Manager URLs field no longer allows me to type a comma at the end of the line. This is problematic because it is a comma-separated list so a user who wants to add multiple URLs directly via the field will expect to be able to add a URL, then a comma, then the next URL.

1. Select File > Preferences... from the Arduino IDE menus.
2. Type a URL into the "Additional Boards Manager URLs" field.
3. Type ,

🐛 The expected , character is not added. If you don't notice then the next URL will not be separated from the previous one.

It does allow commas to be added within existing text. It is only ignored when adding one at the end of the line.

[ubidefeo]

@kittaakos please address changes requested by @per1234 so I can approve this

[kittaakos]

Thanks for the note. I did not forget about this. I will try to find some time to update the PR this week, @ubidefeo. The bug reported by Per is valid. I most likely need to change the <input> from a controlled React component to an uncontrolled one. To sum up, the fix is slightly bigger than I have expected.

[kittaakos]

I have updated this PR. This time, I spent more time verifying my changes locally. Hopefully, I did not overlook anything and fixed the issue. Please review. Thank you!

[per1234]

Working perfectly for me now. Thanks Akos!