Allow leading underscore in sketch filenames #510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the test data for the unit tests of this function did not provide full coverage of all valid sketch filename formats.
The Arduino Sketch Specification defines the allowed format of sketch folder names and sketch code filenames. Arduino Lint's rule SS002 checks compliance with the specification. The Arduino Sketch Specification has been changed to allow a leading underscore in sketch folder names and sketch code filenames so the Arduino Lint rule code must be updated accordingly.
per1234
added
topic: code
per1234
changed the title
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #510 +/- ##
=======================================
Coverage 90.05% 90.05%
=======================================
Files 44 44
Lines 6800 6800
=======================================
Hits 6124 6124
Misses 553 553
Partials 123 123
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
cmaglie
approved these changes
Mar 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Arduino Sketch Specification defines the allowed format of sketch folder names and sketch code filenames. Arduino Lint's rule SS002 checks compliance with the specification.
The Arduino Sketch Specification is being changed to allow a leading underscore in sketch folder names and sketch code filenames:
arduino/arduino-cli#2105
The Arduino Lint rule code must be updated accordingly.