Skip to content

Various tweaks #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Mar 20, 2024
Merged

Various tweaks #11

merged 9 commits into from
Mar 20, 2024

Conversation

sebromero
Copy link
Collaborator

This PR contains various fixes and small enhancements:

  • Fix incorrect file extension in package file: Template file was not included correctly in package file
  • Remove unused variables: Unused variables in runtime file were removed
  • Remove test code: Test code in runtime is better added to a file that is not part of the runtime itself
  • Add additional documentation: Improve documentation in the code
  • Add type hints: Added type hints to functions from runtime
  • Move meta data to init file: Meta data should live in the init file
  • Clarify various points in readme file: Read through the readme and addressed some unclarities.
  • Avoid platform specific duty cycles: Changed analog_write function to use non-platform specific API.
  • Make version consistent: Version in init and package file were different.

@sebromero sebromero requested a review from ubidefeo March 20, 2024 16:39
@sebromero sebromero changed the base branch from main to dev March 20, 2024 16:39
Copy link
Contributor

@ubidefeo ubidefeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great contribution
LGTM

@sebromero sebromero merged commit f1d9916 into dev Mar 20, 2024
@sebromero sebromero deleted the tweaks branch March 20, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants