remove patch 0002 #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
umbynos
added
type: enhancement
per1234
approved these changes
Jul 1, 2022
There was a problem hiding this comment.
I have verified that avrdudes/avrdude#996 fixes arduino/ArduinoCore-megaavr#33.
That will make the patch removed here unnecessary once a version of AVRDUDE which includes avrdudes/avrdude#996 is used by the build.
Thanks Umberto!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove
0002-Try-to-run-ChipErase-on-UDPI-even-if-return-code-is--67.patchsince avrdudes/avrdude#996 fixes the problem (for more details see discussion on the PR linked above).I would merge this PR only shortly before a version bump of avrdude in this repo, since we are currently building avrdude v7.0. Otherwise, the fix would not be there