Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): remove archived arduino/report-size-trends action #191

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

Rotzbua
Copy link
Contributor

@Rotzbua Rotzbua commented Oct 17, 2023

Action not available anymore.

Copy link
Collaborator

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Despite the repository being archived, the arduino/report-size-trends action is still available for use in GitHub Actions workflows.

However, despite the action being created at their request, it turned out that in practice the developers never used the data it produced so it was determined to not be worth the effort to continue the maintenance of the project. So I do think it is a good idea to remove the mention of that action from this action's documentation.

Thanks @Rotzbua

@per1234 per1234 added topic: documentation Related to documentation for the project type: enhancement Proposed improvement labels Oct 17, 2023
@per1234 per1234 self-assigned this Oct 17, 2023
@per1234 per1234 merged commit 735755f into arduino:main Oct 17, 2023
15 checks passed
@Rotzbua
Copy link
Contributor Author

Rotzbua commented Oct 19, 2023

I think when a developer wants to analyze the data they feed it into their familiar metrics tool, since this action uses the very easily processable JSON format :)

Furthermore, the metric is only useful for application projects, since the total resource consumption is taken into account. For libraries it is unfortunately less useful. Because it is always considered the entire resource changes. Thus also includes changes by the Framework (Arduino/ESP) and not only those by the Library.

@Rotzbua Rotzbua deleted the patch-1 branch October 19, 2023 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: documentation Related to documentation for the project type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants