-
-
Notifications
You must be signed in to change notification settings - Fork 16
output compilation time for each sketch #61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #61 +/- ##
===========================================
- Coverage 100.00% 99.81% -0.19%
===========================================
Files 2 2
Lines 1598 1609 +11
===========================================
+ Hits 1598 1606 +8
- Misses 0 3 +3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @2bndy5
I'm thinking that the printout should only be done when the compilation was successful. The reason is that I don't think the information is really useful in that case.
elapsed time is only output if compilation did not fail.
Co-authored-by: per1234 <accounts@perglass.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @2bndy5!
resolves #59
This is a very simple approach. If I knew the code-base better, then I'd decorate a function (like
run_command()
), but the basic aim for #59 is only meant for timing compilation of sketches instead of other action operations.