Skip to content

output compilation time for each sketch #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 18, 2022
Merged

Conversation

2bndy5
Copy link
Contributor

@2bndy5 2bndy5 commented Apr 18, 2022

resolves #59

This is a very simple approach. If I knew the code-base better, then I'd decorate a function (like run_command()), but the basic aim for #59 is only meant for timing compilation of sketches instead of other action operations.

@CLAassistant
Copy link

CLAassistant commented Apr 18, 2022

CLA assistant check
All committers have signed the CLA.

@codecov-commenter
Copy link

codecov-commenter commented Apr 18, 2022

Codecov Report

Merging #61 (9754d0d) into main (a570356) will decrease coverage by 0.18%.
The diff coverage is 72.72%.

@@             Coverage Diff             @@
##              main      #61      +/-   ##
===========================================
- Coverage   100.00%   99.81%   -0.19%     
===========================================
  Files            2        2              
  Lines         1598     1609      +11     
===========================================
+ Hits          1598     1606       +8     
- Misses           0        3       +3     
Impacted Files Coverage Δ
compilesketches/compilesketches.py 99.54% <70.00%> (-0.46%) ⬇️
compilesketches/tests/test_compilesketches.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a570356...9754d0d. Read the comment docs.

Copy link
Collaborator

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @2bndy5

I'm thinking that the printout should only be done when the compilation was successful. The reason is that I don't think the information is really useful in that case.

@per1234 per1234 added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Apr 18, 2022
2bndy5 added 2 commits April 18, 2022 07:18
elapsed time is only output if compilation did not fail.
2bndy5 and others added 2 commits April 18, 2022 14:13
Co-authored-by: per1234 <accounts@perglass.com>
Copy link
Collaborator

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @2bndy5!

@per1234 per1234 self-assigned this Apr 18, 2022
@per1234 per1234 merged commit f91d192 into arduino:main Apr 18, 2022
@2bndy5 2bndy5 deleted the patch-for-#59 branch April 18, 2022 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

output compile time for each sketch
4 participants