Skip to content

Warning for unlisted folders #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 17, 2024

Conversation

Matteo-it
Copy link

Jira task: https://arduino.atlassian.net/jira/software/projects/WEDO/boards/381?selectedIssue=WEDO-5672

Actually trying to render a resources inside _unlisted folder show an error and block the build. This PR is to update the error in Warning, so the build will run.

cc. @jhansson-ard

@Matteo-it Matteo-it force-pushed the Matteo-it/warning-for-unlisted-folders branch from 19db2ea to 49bba02 Compare May 17, 2024 07:23
Copy link
Collaborator

@sebromero sebromero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changes the behaviour of the linter which is not desirable. Instead, I would adjust the logic so that it can deal with the need of ignoring certain folders. Let me push a change to your branch.

@sebromero sebromero force-pushed the Matteo-it/warning-for-unlisted-folders branch from 49bba02 to b8f31ec Compare May 17, 2024 07:40
@Matteo-it
Copy link
Author

This changes the behaviour of the linter which is not desirable. Instead, I would adjust the logic so that it can deal with the need of ignoring certain folders. Let me push a change to your branch.

Thank you @sebromero 👍🏻

@sebromero sebromero merged commit 4180959 into main May 17, 2024
3 checks passed
@sebromero sebromero deleted the Matteo-it/warning-for-unlisted-folders branch May 17, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants