fix crash with templates containing shifts

[facchinm]

twin commit: arduino/arduino-builder#118

[focalintent]

Doesn't breaking out of here put the parsing in a weird state, as now it will go forward parsing while inside a template parameter list?

(Also completely missed that there was already a pull request for this when one of my users pinged me about this being a problem w/FastLED).

[facchinm]

I can't really understand what you mean, this part of the patch looks for "<<" pattern inside a template, so going on parsing while ignoring the shift should be safe.
The other part takes care of not failing completely if we are unable to find the closing '>'

Whit this patch the snippet

template <int P> class c {};
c< 8 > bVar;
c< 1<<8 > aVar;
c< 1>>8 > cVar;

produces

bVar    /home/martino/arduino-builder/src/arduino.cc/builder/test/sketch11/sketch_fastleds.ino  /^c< 8 > bVar;$/;"  kind:variable   line:30
aVar    /home/martino/arduino-builder/src/arduino.cc/builder/test/sketch11/sketch_fastleds.ino  /^c< 1<<8 > aVar;$/;"   kind:variable   line:31
cVar    /home/martino/arduino-builder/src/arduino.cc/builder/test/sketch11/sketch_fastleds.ino  /^c< 1>>8 > cVar;$/;"   kind:variable   line:32

Should be ok, right? 😄

[focalintent]

There's still cases that it will miss - for example:

template <int P> class c {};
c< 8 > bVar;
c< 1<<8 > aVar;

template<int X> func( c< 1<<X> & aParam) {
}

it will fail to parse out the definition for func, only dumping out aVar/bVar - because it's punted on trying to keep things balanced, it's just going to walk forward until the {.

The desired output would be:

./ctags -u --language-force=c++ -f - --c++-kinds=svpf --fields=KSTtzns --line-directives /tmp/x.cpp --verbose
bVar    /tmp/x.cpp  /^c< 8 > bVar;$/;"  kind:variable   line:2
aVar    /tmp/x.cpp  /^c< 1<<8 > aVar;$/;"   kind:variable   line:3
func    /tmp/x.cpp  /^template<int X> func( c< 1<<X> & aVar) {$/;"  kind:function   line:5  signature:( c< 1<<X> & aVar)    returntype:template