Use standardized pin macros in Nano ESP32 "default" sketch #1960
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This sketch is intended to produce the LED blinking behavior the board has when shipped. Previously, bespoke pin name macros were defined in the sketch, which were problematic: The green and blue LED pin numbers were only appropriate for the first limited run of the board that used a different RGB LED than the LED on subsequent runs of the board, which the majority of customers will have. The pin numbers were not correct when the development tool had the "By Arduino pin (default)" pin numbering configuration. The "Arduino ESP32 Boards" core provides pin macros for all four of the LEDs. Using these macros in the sketch sets an example of best practices programming for the reader and fixes both the problems that were present in the previous version of the sketch: The LED_GREEN and LED_BLUE are the correct pin numbers for the LEDs on the majority of the Nano ESP32 boards. These macros are configured to be correct for both pin numbering configurations.
per1234
added
enhancement
pillo79
approved these changes
May 20, 2024
|
Hello, thank you both Being Karl out at this moment I'm adding @jacobhylen to make sure we properly apply the changes with content knowledge to avoid unexpected changes or problems. Please @jacobhylen double check or merge if everything is fine by your part :) |
jacobhylen
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sketch is intended to produce the LED blinking behavior the board has when shipped. Previously, bespoke pin name macros were defined in the sketch, which were problematic:
The green and blue LED pin numbers were only appropriate for the first limited run of the board that used a different RGB LED than the LED on subsequent runs of the board, which the majority of customers will have.
The pin numbers were not correct when the development tool had the "By Arduino pin (default)" pin numbering configuration.
What This PR Changes
The "Arduino ESP32 Boards" core provides pin macros for all four of the LEDs. Using these macros in the sketch sets an example of best practices programming for the reader and fixes both the problems that were present in the previous version of the sketch:
The
LED_GREENandLED_BLUEmacros are the correct pin numbers for the LEDs on the majority of the Nano ESP32 boards.These macros are configured to be correct for both pin numbering configurations.
Contribution Guidelines
Originally reported at https://forum.arduino.cc/t/confusing-pin-numbering-in-the-default-sketch/1260852