File Manager view triggers file-list on switch. #184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ubi de feo <me@ubidefeo.com>
Signed-off-by: ubi de feo <me@ubidefeo.com>
Collaborator
|
@ubidefeo Can you provide some information why you added a "sleep"? What was the issue? |
Collaborator
Author
|
@sebromero |
sebromero
requested changes
Apr 15, 2025
Collaborator
sebromero
left a comment
sebromero
left a comment
There was a problem hiding this comment.
Please add a comment for why we added the sleep
ui/arduino/store.js
Outdated
| } | ||
| if(view === 'file-manager') { | ||
| emitter.emit('stop') | ||
| await sleep(500) |
Collaborator
There was a problem hiding this comment.
Suggested change
| await sleep(500) | |
| await sleep(500) // Give the board time to stop the program and return to the prompt |
Signed-off-by: ubi de feo <me@ubidefeo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.