Product name change and bugfixes #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
murilopolese
commented
Nov 18, 2022
murilopolese
commented
- Change product name and reflect changes on documentation and configuration files
- Update licence disclaimer
- Add copy and paste icons to REPL panel
- Filter out "dot files" from displaying on file manager
- Escape strings when saving file on board
The repository name was changed to "lab-micropython-editor", but some code and documentation still referenced the previous repository name.
There is an edge case when the filename is being edited and a file is being requested from the board. Both things will try to execute commands over serial on the board at the same time. There should be a stack/queue of commands to be executed sequentially but this is not in the specification. Meanwhile the filename saving operation will take priority.
Strings with `\'` or `\"` gets double escaping: `\\'` and `\\"`
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.