Update micropython.js and initial windows width #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ubidefeo
reviewed
Mar 1, 2023
| @@ -38,10 +38,11 @@ | |||
| "license": "MIT", | |||
| "dependencies": { | |||
| "about-window": "^1.15.2", | |||
| "micropython.js": "github:murilopolese/micropython.js#v1.2.2", | |||
There was a problem hiding this comment.
so now the micropython.js is a module brought in from your repo?
interesting :)
There was a problem hiding this comment.
For now, I would propose so. In the future it should be a npm package under the Arduino organization, I believe.
ubidefeo
reviewed
Mar 1, 2023
| @@ -15,7 +15,7 @@ function store(state, emitter) { | |||
| const disk = window.BridgeDisk | |||
| const win = window.BridgeWindow | |||
|
|
|||
| win.setWindowSize(700, 640) | |||
| win.setWindowSize(720, 640) | |||
There was a problem hiding this comment.
why do we need to set the window's size when it's already set in its initial new BrowserWindow() call?
There was a problem hiding this comment.
It's because the app sets a default global screen constraints and the UI can "request" new window constraints. In this case particularly it's the same value.
ubidefeo
approved these changes
Mar 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
micropython.jsas a library installed from a repository branchmicropython.js