Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump go.bug.st/relaxed-semver from 0.11.0 to 0.12.0 #224

Merged
merged 2 commits into from
Aug 29, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 23, 2023

Bumps go.bug.st/relaxed-semver from 0.11.0 to 0.12.0.

Release notes

Sourced from go.bug.st/relaxed-semver's releases.

Release v0.12.0

What's Changed

Full Changelog: bugst/relaxed-semver@v0.11.0...v0.12.0

Commits
  • b4bf3c6 Merge pull request #17 from bugst/performance
  • 391e859 Merge pull request #19 from bugst/templated_resolver
  • fee3392 Fixed another bug in comparator
  • 89efb15 Fixed JSON/YAML/Binary parsing
  • ae9c7ba coverage to 100% again
  • a325c52 Made Resolver state variables as fields
  • 00b3516 Simplified loop
  • 8711f89 Renamed Archive -> Resolver
  • 9f1049e Implemented dependency-templated resolver
  • e8b9735 Merge pull request #18 from bugst/go1.21
  • Additional commits viewable in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added the topic: infrastructure Related to project infrastructure label Nov 23, 2023
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As exposed by the CI, this introduces some errors:

Error: ../../../go/pkg/mod/go.bug.st/relaxed-semver@v0.12.0/resolver.go:18:16: syntax error: unexpected Dependency, expecting ]
Error: ../../../go/pkg/mod/go.bug.st/relaxed-semver@v0.12.0/resolver.go:26:17: syntax error: unexpected Release, expecting ]
Error: ../../../go/pkg/mod/go.bug.st/relaxed-semver@v0.12.0/resolver.go:29:19: syntax error: unexpected [, expecting comma or )
Error: ../../../go/pkg/mod/go.bug.st/relaxed-semver@v0.12.0/resolver.go:30:18: syntax error: unexpected [ after top level declaration
Error: ../../../go/pkg/mod/go.bug.st/relaxed-semver@v0.12.0/resolver.go:41:19: syntax error: unexpected [, expecting comma or )
Error: ../../../go/pkg/mod/go.bug.st/relaxed-semver@v0.12.0/resolver.go:42:33: method has multiple receivers
Error: ../../../go/pkg/mod/go.bug.st/relaxed-semver@v0.12.0/resolver.go:42:38: syntax error: unexpected {, expecting (
Error: ../../../go/pkg/mod/go.bug.st/relaxed-semver@v0.12.0/resolver.go:43:3: syntax error: unexpected return, expecting )
Error: ../../../go/pkg/mod/go.bug.st/relaxed-semver@v0.12.0/resolver.go:49:17: syntax error: unexpected Release, expecting ]
Error: ../../../go/pkg/mod/go.bug.st/relaxed-semver@v0.12.0/resolver.go:[59](https://github.com/arduino/libraries-repository-engine/actions/runs/6973820214/job/18978496453?pr=224#step:6:60):17: syntax error: unexpected [, expecting (
Error: ../../../go/pkg/mod/go.bug.st/relaxed-semver@v0.12.0/resolver.go:59:17: too many errors

I believe these are caused by the go.bug.st/relaxed-semver module's use of features that are not available in the 1.17 version of Go currently used with this project. The module now specifies minimum compatibility of Go 1.21: bugst/relaxed-semver#18.

So merging of this PR must be put on hold until we are able to find time to update the project to using a newer version of Go.

@dependabot dependabot bot force-pushed the dependabot/go_modules/go.bug.st/relaxed-semver-0.12.0 branch from 0edaf00 to 10cb9f1 Compare December 7, 2023 03:50
@per1234 per1234 added the status: on hold Do not proceed at this time label Dec 7, 2023
@dependabot dependabot bot force-pushed the dependabot/go_modules/go.bug.st/relaxed-semver-0.12.0 branch from 10cb9f1 to 6a07237 Compare December 19, 2023 17:14
@cmaglie
Copy link
Member

cmaglie commented Aug 29, 2024

@dependabot rebase

Bumps [go.bug.st/relaxed-semver](https://github.com/bugst/relaxed-semver) from 0.11.0 to 0.12.0.
- [Release notes](https://github.com/bugst/relaxed-semver/releases)
- [Commits](bugst/relaxed-semver@v0.11.0...v0.12.0)

---
updated-dependencies:
- dependency-name: go.bug.st/relaxed-semver
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/go_modules/go.bug.st/relaxed-semver-0.12.0 branch from 6a07237 to 1ea8b6e Compare August 29, 2024 10:30
@cmaglie cmaglie requested a review from per1234 August 29, 2024 10:40
@per1234 per1234 added type: enhancement Proposed improvement and removed status: on hold Do not proceed at this time labels Aug 29, 2024
@cmaglie cmaglie merged commit fdb6e4c into main Aug 29, 2024
43 checks passed
@cmaglie cmaglie deleted the dependabot/go_modules/go.bug.st/relaxed-semver-0.12.0 branch August 29, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: infrastructure Related to project infrastructure type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants