Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump actions/upload-artifact from 3 to 4 #231

Merged
merged 5 commits into from
Oct 20, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/check-go-dependencies-task.yml
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ jobs:
# Some might find it convenient to have CI generate the cache rather than setting up for it locally
- name: Upload cache to workflow artifact
if: failure() && steps.diff.outcome == 'failure'
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
if-no-files-found: error
include-hidden-files: true
Expand Down
23 changes: 14 additions & 9 deletions .github/workflows/compare-performance.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name: Compare Performance

env:
REPORTS_ARTIFACT_NAME: reports
REPORTS_ARTIFACT_PREFIX: reports-

# See: https://docs.github.com/en/free-pro-team@latest/actions/reference/events-that-trigger-workflows
on:
Expand Down Expand Up @@ -85,16 +85,20 @@ jobs:
matrix:
data:
# Use two copies of each job to catch job-specific anomalous durations.
- ref: ${{ github.ref }} # The tip of the branch selected in the workflow dispatch dialog's "Use workflow from" menu
- artifact-suffix: tip-run-1
ref: ${{ github.ref }} # The tip of the branch selected in the workflow dispatch dialog's "Use workflow from" menu
description: tip run 1
position: after
- ref: ${{ github.ref }}
- artifact-suffix: tip-run-2
ref: ${{ github.ref }}
description: tip run 2
position: after
- ref: ${{ needs.init.outputs.base-ref }}
- artifact-suffix: comparison-run-1
ref: ${{ needs.init.outputs.base-ref }}
description: comparison run 1
position: before
- ref: ${{ needs.init.outputs.base-ref }}
- artifact-suffix: comparison-run-2
ref: ${{ needs.init.outputs.base-ref }}
description: comparison run 2
position: before

Expand Down Expand Up @@ -294,11 +298,11 @@ jobs:
EOF

- name: Upload report to a workflow artifact
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
if-no-files-found: error
path: ${{ env.REPORTS_PATH }}
name: ${{ env.REPORTS_ARTIFACT_NAME }}
name: ${{ env.REPORTS_ARTIFACT_PREFIX }}${{ matrix.data.artifact-suffix }}

results:
needs: run
Expand All @@ -310,10 +314,11 @@ jobs:

steps:
- name: Download reports
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: ${{ env.REPORTS_ARTIFACT_NAME }}
merge-multiple: true
path: ${{ env.REPORTS_PATH }}
pattern: ${{ env.REPORTS_ARTIFACT_PREFIX }}*

- name: Print results
shell: python
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/publish-go-tester-task.yml
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ jobs:
"./LICENSE.txt"

- name: Save binary as workflow artifact
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
if-no-files-found: error
path: ${{ env.BUILD_ARCHIVE_PATH }}
Expand Down
19 changes: 10 additions & 9 deletions .github/workflows/sync-labels-npm.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ env:
# See: https://github.com/actions/setup-node/#readme
NODE_VERSION: 16.x
CONFIGURATIONS_FOLDER: .github/label-configuration-files
CONFIGURATIONS_ARTIFACT: label-configuration-files
CONFIGURATIONS_ARTIFACT_PREFIX: label-configuration-file-

# See: https://docs.github.com/actions/using-workflows/events-that-trigger-workflows
on:
Expand Down Expand Up @@ -84,13 +84,13 @@ jobs:
file-url: https://raw.githubusercontent.com/arduino/tooling-project-assets/main/workflow-templates/assets/sync-labels/${{ matrix.filename }}

- name: Pass configuration files to next job via workflow artifact
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
path: |
*.yaml
*.yml
if-no-files-found: error
name: ${{ env.CONFIGURATIONS_ARTIFACT }}
name: ${{ env.CONFIGURATIONS_ARTIFACT_PREFIX }}${{ matrix.filename }}

sync:
needs: download
Expand Down Expand Up @@ -124,16 +124,17 @@ jobs:
- name: Checkout repository
uses: actions/checkout@v4

- name: Download configuration files artifact
uses: actions/download-artifact@v3
- name: Download configuration file artifacts
uses: actions/download-artifact@v4
with:
name: ${{ env.CONFIGURATIONS_ARTIFACT }}
merge-multiple: true
pattern: ${{ env.CONFIGURATIONS_ARTIFACT_PREFIX }}*
path: ${{ env.CONFIGURATIONS_FOLDER }}

- name: Remove unneeded artifact
uses: geekyeggo/delete-artifact@v2
- name: Remove unneeded artifacts
uses: geekyeggo/delete-artifact@v5
with:
name: ${{ env.CONFIGURATIONS_ARTIFACT }}
name: ${{ env.CONFIGURATIONS_ARTIFACT_PREFIX }}*

- name: Setup Node.js
uses: actions/setup-node@v4
Expand Down
Loading