Use a dedicated output field to indicate request conclusion #219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In cases where the request submitter or the submitted repositories are from entities without registry access privileges, the parser can determine the conclusion of the request. When the access control system was implemented, the pre-existing `type` field was used to pass this information. That field is used in two ways: - Determine the appropriate handling for the request. - Apply the appropriate labeling to the pull request. Although the `type` field is suitable for the first of these in the case where the request is declined, it is not very suitable for the second. The reason is that the labels are grouped in sets. The type data corresponds to the "topic" label set, while the conclusion corresponds to the "conclusion" set. The PR should be labeled with the appropriate label from each of these sets. So the request conclusion data is moved to a dedicated `conclusion` output field, leaving the `type` field to be used exclusively for its original purpose.
per1234
added
type: enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In cases where the request submitter or the submitted repositories are from entities without registry access privileges, the parser can determine the conclusion of the request. When the access control system was implemented, the pre-existing
typefield was used to pass this information. That field is used in two ways:Although the
typefield is suitable for the first of these in the case where the request is declined, it is not very suitable for the second. The reason is that the labels are grouped in sets. The type data corresponds to the "topic" label set, while the conclusion corresponds to the "conclusion" set. The PR should be labeled with the appropriate label from each of these sets.So the request conclusion data is moved to a dedicated
conclusionoutput field, leaving thetypefield to be used exclusively for its original purpose.