Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update repositories.txt #2330

Closed
wants to merge 1 commit into from
Closed

Update repositories.txt #2330

wants to merge 1 commit into from

Conversation

dvarrel
Copy link
Contributor

@dvarrel dvarrel commented Jan 3, 2023

remove .git from my librairries. Hope pb with ESPAsynWebsrv resolved

remove .git from my librairries
@github-actions
Copy link
Contributor

github-actions bot commented Jan 3, 2023

Hi @dvarrel.
Your pull request has been detected as something other than a Library Manager submission.
A maintainer will need to review it before it can be merged.

If you intended to submit a library, please check the instructions and update your pull request if necessary:
https://github.com/arduino/library-registry/blob/main/README.md#instructions

@github-actions
Copy link
Contributor

github-actions bot commented Jan 3, 2023

A problem was found with your submission https://github.com/dvarrel/ESPAsyncTCP

ERROR: Submission URL is already in the Library Manager index.

@github-actions github-actions bot added the topic: modification Change existing list entry label Jan 3, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jan 3, 2023

A problem was found with your submission https://github.com/dvarrel/AsyncTCP

ERROR: Submission URL is already in the Library Manager index.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 3, 2023

A problem was found with your submission https://github.com/dvarrel/TM1638

ERROR: Submission URL is already in the Library Manager index.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 3, 2023

Thanks for your interest in contributing to the Arduino Library Manager index @dvarrel
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@github-actions github-actions bot requested a review from per1234 January 3, 2023 23:09
@per1234 per1234 self-assigned this Jan 4, 2023
@per1234 per1234 added the status: waiting for information More information must be provided before work can proceed label Jan 4, 2023
@per1234
Copy link
Contributor

per1234 commented Jan 4, 2023

Hi @dvarrel the Library Manager system accepts library repository URLs with or without the .git suffix.

You are welcome to remove the suffix from your library URLs if you like, but you stated the purpose of this PR is:

Hope pb with ESPAsynWebsrv resolved

Doing this will never fix any problem, so there is no point in making this change for that purpose.

I am happy to help you to find a solution for the problem, but I can only do that if I understand what the problem is. Please provide a detailed description of the problem:

  • What did you do?
  • What were the results you expected from doing that?
  • What were the results you observed that did not match your expectations?
    • Make sure to include the full and exact text of any error or warning message you might have encountered.

@dvarrel
Copy link
Contributor Author

dvarrel commented Jan 4, 2023

When i try to install , I see "Processing ESPAsyncWebsrv 1.2.5" and that's all, the installation fails.
Is there any log to see ?

@dvarrel
Copy link
Contributor Author

dvarrel commented Jan 4, 2023

i don't see AsyncTCP in the library manager, and ESPAsyncWebsrv depends on it.
that's a possible issue

@per1234
Copy link
Contributor

per1234 commented Jan 4, 2023

Is there any log to see ?

There are logs, but unfortunately they don't show this problem. However, you can see the bot tried to warn you about a problem when you submitted the library:

#2235 (comment)

WARNING: library.properties depends field item(s) AsyncTCP, ESPAsyncTCP not found in the Library Manager index.
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
         (Rule LP048)         

i don't see AsyncTCP in the library manager, and ESPAsyncWebsrv depends on it.
that's a possible issue

That is exactly it. The library installation fails because the library references a dependency that can not be installed:

https://github.com/dvarrel/ESPAsyncWebSrv/blob/1.2.5/library.properties#L10

depends=AsyncTCP, ESPAsyncTCP

Unfortunately Arduino IDE 2.x does not communicate about the problem to the user, but instead silently fails the installation:

arduino/arduino-ide#621

So there are two possible solutions to the problem:

Remove the unavailable library from the depends field

The user is responsible for manually installing the AsyncTCP library dependency. I recommend providing detailed instructions for how to install that dependency in the library's readme.

You will need to make a new release of the ESPAsyncWebSrv library after fixing its metadata:

https://github.com/arduino/library-registry/blob/main/FAQ.md#how-can-i-publish-a-new-release-once-my-library-is-in-the-list

Submit the missing dependency to Arduino Library Manager

Unfortunately the library author has not been responsive to requests to add these popular libraries to Arduino Library Manager:

me-no-dev/AsyncTCP#147

Although anyone is welcome to submit any library, we are unable to submit that one because its repository doesn't have a tag.

You can fork the library and then submit the fork to Arduino Library Manager. I see you actually have already forked it and submitted that fork: #2233
But you registered it under the name ESP32AsyncTCP instead of AsyncTCP. So maybe you referenced the wrong name in the depends field of the ESPAsyncWebSrv library???

@per1234 per1234 closed this Jan 4, 2023
@per1234 per1234 added conclusion: invalid Issue/PR not valid and removed status: waiting for information More information must be provided before work can proceed labels Jan 4, 2023
@dvarrel
Copy link
Contributor Author

dvarrel commented Jan 4, 2023

library is in line 5459 in repositories.txt https://github.com/dvarrel/AsyncTCP.git
perhaps the name has change.
May i have to reove it and then submit ?

@per1234
Copy link
Contributor

per1234 commented Jan 4, 2023

Please submit a name change request by following these instructions:

https://github.com/arduino/library-registry/blob/main/FAQ.md#how-can-i-change-a-librarys-name

I see the latest tag in the library repository already has the desired name:

https://github.com/dvarrel/AsyncTCP/blob/1.1.3/library.properties#L1

so you only need to submit the request and we'll take care of the rest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conclusion: invalid Issue/PR not valid topic: modification Change existing list entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants