Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #4584: Removal of https://github.com/lacamera/ESPAsyncWebServer from the registry. #4585

Closed
wants to merge 2 commits into from

Conversation

mathieucarbou
Copy link
Contributor

@mathieucarbou mathieucarbou commented May 28, 2024

Reasons:

Advise for @lacamera:

  • Either re-upload the library under a different name
  • Or use the maintained fork above which is more advanced than ESPHome's fork

Please see the wrong state of the library registry here: https://www.arduinolibraries.info/libraries/esp-async-web-server

…erver from the registry.

Reasons:
- Project was wrongly renamed
- Original author was wrongly changed from me-no-dev to lacamera
- The repository is a fork of ESPHome, which is old and outdated and miss some important fixes and stability improvements
- The deployed artifact (3.x from this repo) are overriding versions 2.x of the (correctly) maintained ESPAsyncWebServer fork at https://github.com/mathieucarbou/ESPAsyncWebServer
- The maintained ESPAsyncWebServer at https://github.com/mathieucarbou/ESPAsyncWebServer is more advanced and is compatible with Arduino 3

Advise for @lacamera:
- Either re-upload the library under a different name
- Or use the maintained fork above which is more advanced than ESPHome's fork
Copy link
Contributor

Hi @mathieucarbou.
Your pull request has been detected as something other than a Library Manager submission.
A maintainer will need to review it before it can be merged.

If you intended to submit a library, please check the instructions and update your pull request if necessary:
https://github.com/arduino/library-registry/blob/main/README.md#instructions

@github-actions github-actions bot added the topic: removal Remove library from the list label May 28, 2024
@github-actions github-actions bot requested a review from per1234 May 28, 2024 20:04
Copy link
Contributor

github-actions bot commented Jun 2, 2024

Hi @mathieucarbou.
Your pull request has been detected as something other than a Library Manager submission.
A maintainer will need to review it before it can be merged.

If you intended to submit a library, please check the instructions and update your pull request if necessary:
https://github.com/arduino/library-registry/blob/main/README.md#instructions

@per1234 per1234 self-assigned this Jun 20, 2024
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mathieucarbou. Thanks for your report. I have investigated the situation and determined there are no grounds for us to accommodate the requested removal.

I think that the root of your concern is a bug in the arduinolibraries.info website. As you correctly point out, for some reason the listings for the "ESP Async WebServer" library you maintain are shown under the data for the "ESPAsyncWebServer" maintained by @lacamera on that website.

Although arduinolibraries.info is built from the Arduino Library Manager index data that originates from the data here in the Arduino Library Registry, it is a 3rd party project. Arduino does not have any involvement in the maintenance of that project. So defects that are specific to the arduinolibraries.info website must be reported to the issue tracker for that codebase:

https://github.com/njh/arduino-libraries/issues

As for the parts of the system for which Arduino is responsible, I don't find any problems at all. If you look in the Arduino IDE Library Manager, you can see that listings for the two libraries are as expected:

image

image


To address each of the points you made individually:

Project was wrongly renamed

It was not renamed in the Arduino Library Registry, but rather only in
the arduinolibraries.info website. In the registry, and in the official Arduino development software (Arduino IDE, Arduino CLI, Arduino Cloud Editor) the library you maintained continues to use the name "ESP Async WebServer" and the library maintained by @lacamera the name "ESPAsyncWebServer".

Original author was wrongly changed from me-no-dev to lacamera

The author data in the Arduino Library Manager index for the "ESP Async WebServer" library you maintain has the value Me-No-Dev, as specified in the library's metadata file:

https://github.com/mathieucarbou/ESPAsyncWebServer/blob/v2.10.8/library.properties#L3

author=Me-No-Dev

Likewise, the author data in the index for the "ESPAsyncWebServer" maintained by @lacamera has the value specified in that library's metadata file:

https://github.com/lacamera/ESPAsyncWebServer/blob/3.1.0/library.properties#L3

author=lacamera

It is absolutely reasonable to consider it inappropriate for the author attribution to be changed in this way. In fact, we provide the maintainer field specifically in order to allow attribution for the library maintainer to be specified while still preserving the attribution for authorship (which we see from these examples is not always the same). But that is something to take up with @lacamera. My guess is this was an honest mistake rather something done out of malicious intent (note that they did leave the authorship attribution intact in the readme). So my recommendation is for you to submit a pull request to the lacamera/ESPAsyncWebServer repository to correct the value of the author field.

The repository is a fork of ESPHome, which is old and outdated and miss some important fixes and stability improvements

[...]

The maintained ESPAsyncWebServer at https://github.com/mathieucarbou/ESPAsyncWebServer is more advanced and is compatible with Arduino 3

If @lacamera requests the library be removed then we will be happy to accommodate that, but this is not sufficient grounds for us to remove a library without approval from the library maintainer.

The deployed artifact (3.x from this repo) are overriding versions 2.x of the (correctly) maintained ESPAsyncWebServer fork at https://github.com/mathieucarbou/ESPAsyncWebServer

Other than the problem with the bugged arduinolibraries.info website, I don't see any evidence of this. Of course there can be collisions if a user installs both libraries, but that is a matter of user error rather than grounds for removal of a library from the registry.

@per1234 per1234 closed this Jun 20, 2024
@per1234 per1234 added the conclusion: invalid Issue/PR not valid label Jun 20, 2024
@mathieucarbou
Copy link
Contributor Author

@per1234 : Thanks a lot for your comprehensive reply! I understand the root of the problem now. I really didn't know that arduinolibraries.info was not affiliated. I will pay more attention. As long as the libraries are not mixed up in the real repository, that's fine then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conclusion: invalid Issue/PR not valid topic: removal Remove library from the list
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants