Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update repositories.txt #616

Merged
merged 1 commit into from
Oct 27, 2021
Merged

Update repositories.txt #616

merged 1 commit into from
Oct 27, 2021

Conversation

Rotzbua
Copy link
Contributor

@Rotzbua Rotzbua commented Oct 27, 2021

No description provided.

@github-actions github-actions bot added the topic: submission Add library to the list label Oct 27, 2021
@github-actions
Copy link
Contributor

Arduino Lint has suggestions for possible improvements to https://github.com/OSSLibraries/Arduino_MFRC522v2:

Linting library in Arduino_MFRC522v2
INFO: No header file found matching library name (RFID_MFRC522v2.h). Best practices are for primary header filename to  
      match library name. (Rule LS008)                                                                                  
WARNING: library.properties depends field item(s) Wire, SPI not found in the Library Manager index. (Rule LP048)

Linter results for project: 0 ERRORS, 1 WARNINGS

-------------------

Linting sketch in Arduino_MFRC522v2/examples/CheckFirmware

Linter results for project: no errors or warnings

-------------------

Linting sketch in Arduino_MFRC522v2/examples/CustomI2C

Linter results for project: no errors or warnings

-------------------

Linting sketch in Arduino_MFRC522v2/examples/CustomSPI

Linter results for project: no errors or warnings

-------------------

Linting sketch in Arduino_MFRC522v2/examples/DumpInfo

Linter results for project: no errors or warnings

-------------------

Linting sketch in Arduino_MFRC522v2/examples/Hack/ChangeUID

Linter results for project: no errors or warnings

-------------------

Linting sketch in Arduino_MFRC522v2/examples/Hack/FixBrickedUID

Linter results for project: no errors or warnings

-------------------

Linting sketch in Arduino_MFRC522v2/examples/ReadUidMultiReader

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 0 ERRORS, 1 WARNINGS

@github-actions github-actions bot merged commit c5e04fe into arduino:main Oct 27, 2021
@github-actions
Copy link
Contributor

Your submission has now been accepted! Thanks for your contribution to the Arduino Library Manager index.

The library(s) will be available for installation via Library Manager within a day's time.

You can check the logs from the Library Manager indexer for your library(s) here:
http://downloads.arduino.cc/libraries/logs/github.com/OSSLibraries/Arduino_MFRC522v2/

github-actions bot pushed a commit that referenced this pull request Oct 27, 2021
@Rotzbua
Copy link
Contributor Author

Rotzbua commented Oct 27, 2021

Hi @per1234 .
Short question: Is library property depends just for other libraries and not for internal dependency like SPI and wire?
So https://github.com/OSSLibraries/Arduino_MFRC522v2/blob/8d34a2650137d02a6e6f5ea0c386c394e2fa8296/library.properties#L10 is wrong?

@per1234
Copy link
Contributor

per1234 commented Oct 28, 2021

Hello @Rotzbua !

Is library property depends just for other libraries and not for internal dependency like SPI and wire?

That is correct. the depends field is a list of name values of libraries that should be installed via Library Manager along with the dependent library. So you should only put the names of libraries that are in Library Manager in this field.

At best, anything else in that field will do nothing. At worst, it will cause a problem during the installation of the library (e.g., the installation of RFID_MFRC522v2 in Arduino IDE 2.x currently fails silently).

@Rotzbua
Copy link
Contributor Author

Rotzbua commented Oct 28, 2021

Thanks for the feedback. I changed it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: submission Add library to the list
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants