Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add glpi_esp8266 #688

Merged
merged 1 commit into from
Nov 18, 2021
Merged

add glpi_esp8266 #688

merged 1 commit into from
Nov 18, 2021

Conversation

verdanatech-dev
Copy link
Contributor

No description provided.

@github-actions
Copy link
Contributor

A problem was found with your submission https://github.com/verdanatech/glpi_esp8266.git

ERROR: Library is missing a library.properties metadata file.

See: https://arduino.github.io/arduino-cli/latest/library-specification/#library-metadata

@github-actions github-actions bot added the topic: submission Add library to the list label Nov 18, 2021
@github-actions
Copy link
Contributor

Thanks for your interest in contributing to the Arduino Library Manager index @verdanatech-dev
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@verdanatech-dev
Copy link
Contributor Author

verdanatech-dev commented Nov 18, 2021

@ArduinoBot

@github-actions
Copy link
Contributor

Hello! I'm checking your submission again.

@github-actions
Copy link
Contributor

A problem was found with your submission https://github.com/verdanatech/glpi_esp8266.git

ERROR: Library is missing a library.properties metadata file.

See: https://arduino.github.io/arduino-cli/latest/library-specification/#library-metadata

@github-actions
Copy link
Contributor

Thanks for your interest in contributing to the Arduino Library Manager index @verdanatech-dev
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@verdanatech-dev
Copy link
Contributor Author

@ArduinoBot

@github-actions
Copy link
Contributor

Hello! I'm checking your submission again.

@github-actions
Copy link
Contributor

A problem was found with your submission https://github.com/verdanatech/glpi_esp8266.git

ERROR: Library is missing a library.properties metadata file.

See: https://arduino.github.io/arduino-cli/latest/library-specification/#library-metadata

@github-actions
Copy link
Contributor

Thanks for your interest in contributing to the Arduino Library Manager index @verdanatech-dev
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@per1234
Copy link
Contributor

per1234 commented Nov 18, 2021

Hello @verdanatech-dev. I see you have fixed the error reported by the bot. However, Library Manager works exclusively from Git tags, so the bot won't be able to see the fix you made until you create a new release or tag in the library repository. You can see that at the last tag, the problem still existed:
https://github.com/verdanatech/glpi_esp8266/tree/refs/tags/0.0.1

Remember to update the version field in the library's library.properties file as needed before making a release/tag.

Once you have done that, simply mention @ArduinoBot in a comment here to trigger it to run the automated checks again. After those are passing, your library will automatically be added to Library Manager.

@verdanatech-dev
Copy link
Contributor Author

@ArduinoBot

@github-actions
Copy link
Contributor

Hello! I'm checking your submission again.

@github-actions
Copy link
Contributor

Arduino Lint has suggestions for possible improvements to https://github.com/verdanatech/glpi_esp8266.git:

Linting library in glpi_esp8266
WARNING: library.properties depends field item(s) ESP8266HTTPClient.h, ESP8266WiFi.h not found in the Library Manager   
         index. (Rule LP048)                                                                                            
WARNING: No example sketches found. Please provide examples. See:                                                       
         https://arduino.github.io/arduino-cli/latest/library-specification/#library-examples (Rule LD004)              

Linter results for project: 0 ERRORS, 2 WARNINGS

-------------------

@github-actions github-actions bot merged commit c5ec211 into arduino:main Nov 18, 2021
github-actions bot pushed a commit that referenced this pull request Nov 18, 2021
@github-actions
Copy link
Contributor

Your submission has now been accepted! Thanks for your contribution to the Arduino Library Manager index.

The library(s) will be available for installation via Library Manager within a day's time.

You can check the logs from the Library Manager indexer for your library(s) here:
http://downloads.arduino.cc/libraries/logs/github.com/verdanatech/glpi_esp8266/

@verdanatech-dev
Copy link
Contributor Author

@ArduinoBot

@per1234
Copy link
Contributor

per1234 commented Jan 4, 2022

Hello @verdanatech-dev.

The automated system here only operates on open pull requests submissions. Since your submission was already accepted and the pull request merged, the bot won't pay any more attention to this pull request. But this human is happy to provide assistance. Was there something you needed from the bot?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: submission Add library to the list
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants