Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal request for "FireBase32" #708

Closed
wants to merge 1 commit into from
Closed

Removal request for "FireBase32" #708

wants to merge 1 commit into from

Conversation

RonPTS
Copy link

@RonPTS RonPTS commented Nov 21, 2021

Remove the fake and junk library that will never test and doesn't work from someone that doesn't know the basic of C or C++ programming.

This is the library repository.
https://github.com/ohad32/FireBase32

Here is why it should remove.
https://github.com/ohad32/FireBase32/blob/main/src/FireBase32.h#L24-L34

I hope that the Arduino team should have the process for preliminary testing or validating the library prior to accept the submission.

Remove the fake and junk library that will never test and doesn't work from someone that doesn't know the basic of C or C++.

This is the library repository.
https://github.com/ohad32/FireBase32

Here is why it should remove.
https://github.com/ohad32/FireBase32/blob/main/src/FireBase32.h#L24-L34

I hope that the Arduino team should have the process for preliminary testing or validating the library prior to accept the submission.
@github-actions
Copy link
Contributor

Hi @RonPTS.
Your pull request has been detected as something other than a Library Manager submission.
A maintainer will need to review it before it can be merged.

If you intended to submit a library, please check the instructions and update your pull request if necessary:
https://github.com/arduino/library-registry/blob/main/README.md#instructions

@github-actions github-actions bot added the topic: removal Remove library from the list label Nov 21, 2021
@github-actions github-actions bot requested a review from per1234 November 21, 2021 06:24
@RonPTS
Copy link
Author

RonPTS commented Nov 21, 2021

@per1234

You should check what I requested as to prevent the submission of "programming error library" in to the Arduino libraries list.

@per1234
Copy link
Contributor

per1234 commented Nov 21, 2021

Hello @RonPTS. I appreciate your care for the quality of the libraries available via the Arduino Library Manager.

I will not be able to accept this removal request because our policy is that removals can only be done by the authorization of the library maintainer. Please work with directly with the library maintainer to either improve the library or else get their approval to remove it.

I hope that the Arduino team should have the process for preliminary testing or validating the library prior to accept the submission.

We do, and we have even recently done a significant amount of work to expand such validation.

However, we do not check code quality. In general, that is not possible to do in an automated fashion because the automated system does not have access to the required information. See the discussion here to learn about that.

The library maintainers and contributors must take the responsibility for the quality of their code. We have created several tools to facilitate that effort. Arduino is providing a valuable service by distributing thousands of 3rd party libraries. It is not reasonable to place additional burden on Arduino when we already devote so many resources toward this service.

The entire Library Manager system is open source. If you would like to contribute some enhancements to the automated testing capabilities, please do so.

@per1234 per1234 closed this Nov 21, 2021
@per1234 per1234 added the conclusion: invalid Issue/PR not valid label Nov 21, 2021
@per1234 per1234 self-assigned this Nov 21, 2021
@RonPTS
Copy link
Author

RonPTS commented Nov 21, 2021

Thanks and I understand this and it is hard for the team to buld automate sytem to test the code for all libraries.

I have some advise that to qualify the maintainer that he knows the basic programming and don't submit junk or mistake code to your registry at the step of first submission instead of bugs or compilation errors during library updates, the maintainer should include the Github Action CI script for simple testing his example sketch and it should pass basic example compiling.

You may provide the guides or examples for making CI script for his basic testing in the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conclusion: invalid Issue/PR not valid topic: removal Remove library from the list
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants