fix(phone-as-device): app-478 app-479 fix NPE client is non connected #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alessioemireni
force-pushed
the
fix/APP-478-479-isconnected
branch
from
4402a28 to
7a89049
Compare
Splact
approved these changes
Jul 12, 2023
alessioemireni
force-pushed
the
feat/APP-481-mqtt-csrwithec-ios
branch
2 times, most recently
from
a9e1e3a to
ae056b5
Compare
alessioemireni
force-pushed
the
fix/APP-478-479-isconnected
branch
from
7a89049 to
ed20b62
Compare
alessioemireni
force-pushed
the
fix/APP-478-479-isconnected
branch
from
ed20b62 to
1151263
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this PR is to avoid
NPEwhen the client is subscribing or disconnecting.To do that we need to expose a method to JS,
isConnected, that checks the connection status of the client. The method invokes the methods exposed by underline libraries,Paho Androidfor Android andCocoaMQTTfor iOS.Previously there was no native method that checks connection status of the client and this could create some inconsistency on the code.
If you want to test please refer to this PR https://github.com/bcmi-labs/iot-cloud-remote-ios/pull/356