Skip to content

chore(hook): app-1821 github packages internal build #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

alessioemireni
Copy link
Contributor

@alessioemireni alessioemireni commented Oct 15, 2024

The purpose of this PR is to add a workflow that publish a Github Packages of the library. https://github.com/arduino/react-native-mqtt-client/pkgs/npm/react-native-mqtt-client

To accomplish this we had some challenges:

  • remove the old package.json-lock file and create the yarn.lock
  • update react-native-builder-blob and some configurations
  • add or update some libraries
  • configure eslint and prettier
  • update the version of typescript to v5
  • remove circleci
  • we add the company name to package.json file to comply with other Arduino packages

NOTE: we maintain some libraries like commitlint or some configurations as-is

@alessioemireni alessioemireni self-assigned this Oct 15, 2024
@alessioemireni alessioemireni force-pushed the chore/APP-1821-pkg-mqtt branch 2 times, most recently from f5602de to 46d71c9 Compare October 15, 2024 13:41
@alessioemireni alessioemireni force-pushed the chore/APP-1821-pkg-mqtt branch from e876090 to d2f5405 Compare October 17, 2024 15:06
@alessioemireni alessioemireni force-pushed the chore/APP-1821-pkg-mqtt branch from 35faedd to 64f61d3 Compare October 17, 2024 15:11
Copy link
Contributor

@balsick balsick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@balsick balsick merged commit af29dd9 into main Oct 17, 2024
3 checks passed
@balsick balsick deleted the chore/APP-1821-pkg-mqtt branch March 31, 2025 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants