Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added "rts" and "dtr" configuration parameters. #21

Merged
merged 8 commits into from
Sep 8, 2022
Merged

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Aug 11, 2022

This PR adds the rts and cts configuration parameter that allows to set and reset RTS and CTS lines.

@per1234 per1234 added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Aug 11, 2022
@cmaglie cmaglie changed the title Added "rts" and "cts" configuration parameters. Added "rts" and "dtr" configuration parameters. Aug 30, 2022
go.mod Show resolved Hide resolved
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UPDATE: fixed!

The port is always configured as dtr=on,rts=off after the change made in 37305bb

For example, any of the following commands:

$ arduino-cli monitor -p COM43 --config dtr=off,rts=off
$ arduino-cli monitor -p COM43 --config dtr=on,rts=on
$ arduino-cli monitor -p COM43 --config dtr=off,rts=on

Produce these states:

image

I only checked on Windows. Everything works as expected for me with the version from 4d98996

@cmaglie cmaglie force-pushed the rts_cts_on branch 2 times, most recently from 9e5739b to 8e68f5e Compare September 2, 2022 15:42
@cmaglie
Copy link
Member Author

cmaglie commented Sep 2, 2022

Thanks for testing it @per1234, I messed up with the control bits, now I pushed a new tentative fix in 16a3ef6 (EDIT: just rebased over CI workflow fix)

Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything is working as expected on Windows and Linux with the build from 16a3ef6

@per1234 per1234 added type: imperfection Perceived defect in any part of project and removed type: enhancement Proposed improvement labels Sep 3, 2022
@cmaglie cmaglie merged commit bbe81f9 into main Sep 8, 2022
@cmaglie cmaglie deleted the rts_cts_on branch September 8, 2022 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants