Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

place the parent dir in archive, to have compatibility with the cli #3

Merged
merged 1 commit into from
Sep 20, 2021
Merged

place the parent dir in archive, to have compatibility with the cli #3

merged 1 commit into from
Sep 20, 2021

Conversation

umbynos
Copy link
Contributor

@umbynos umbynos commented Sep 20, 2021

The Arduino CLI fails to install this tool because of the way the archive it's created:

Error initializing instance: installing builtin:serial-monitor@0.9.0 tool: Cannot install tool builtin:serial-monitor@0.9.0: searching package root dir: files in archive must be placed in a subdirectory

@umbynos umbynos added the topic: infrastructure Related to project infrastructure label Sep 20, 2021
@umbynos umbynos requested review from cmaglie and per1234 September 20, 2021 13:05
@umbynos umbynos self-assigned this Sep 20, 2021
This was referenced Sep 20, 2021
Merged
Merged
@cmaglie cmaglie merged commit 6c0ad59 into main Sep 20, 2021
@cmaglie cmaglie deleted the umbynos/enhance_release_files branch September 20, 2021 13:44
@cmaglie
Copy link
Member

cmaglie commented Sep 20, 2021

We must move also LICENSE.txt inside the folder (or maybe remove it?)

umbynos added a commit that referenced this pull request Sep 20, 2021
@umbynos
place license in the created folder too, followup of #3
f408750
@umbynos umbynos mentioned this pull request Sep 20, 2021
Merged
umbynos added a commit that referenced this pull request Sep 20, 2021
@umbynos
Merge pull request #6 from arduino/umbynos/enhance_release_files_2
d8468df 
place license in the created folder too, followup of #3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmaglie cmaglie Awaiting requested review from cmaglie

@per1234 per1234 Awaiting requested review from per1234

Assignees

@umbynos umbynos

Labels
topic: infrastructure Related to project infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@umbynos @cmaglie