Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated DistTask.yml / Add support for macos_ARM64 builds #77

Merged
merged 1 commit into from
Feb 21, 2024
Merged

Updated DistTask.yml / Add support for macos_ARM64 builds #77

merged 1 commit into from
Feb 21, 2024

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Feb 20, 2024 •
edited
Loading

The updated DistTask.yml has been taken from the Arduino CLI project.

@cmaglie cmaglie self-assigned this Feb 20, 2024
@cmaglie cmaglie added type: enhancement Proposed improvement topic: infrastructure Related to project infrastructure labels Feb 20, 2024
@cmaglie cmaglie requested a review from a team February 20, 2024 17:31
@cmaglie cmaglie linked an issue Feb 20, 2024 that may be closed by this pull request
Distribute Apple ARM builds #69
Closed
3 tasks
@cmaglie
Copy link
Member Author

cmaglie commented Feb 20, 2024

I've made a test build and it seems working as expected.

@umbynos
Copy link
Contributor

umbynos commented Feb 21, 2024

Are we 100% sure that CGO is not required? Have you tested if the monitor works correctly on linux/macos?

alessio-perugini
alessio-perugini approved these changes Feb 21, 2024
View reviewed changes
Copy link

@alessio-perugini alessio-perugini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested on Linux and it's working fine. At the moment I don't have other OSs to test it.

@cmaglie
Copy link
Member Author

cmaglie commented Feb 21, 2024

Are we 100% sure that CGO is not required? Have you tested if the monitor works correctly on linux/macos?

Yes, CGO is needed only for the USB enumerator on macOS.
Here we only use the serial port, we don't need the enumerator, and no CGO is needed!

@cmaglie cmaglie merged commit 7c8454b into main Feb 21, 2024
81 checks passed
@cmaglie cmaglie deleted the update_build_process branch February 21, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alessio-perugini alessio-perugini alessio-perugini approved these changes

@umbynos umbynos umbynos approved these changes

Assignees

@cmaglie cmaglie

Labels
topic: infrastructure Related to project infrastructure type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Distribute Apple ARM builds
3 participants
@cmaglie @umbynos @alessio-perugini