Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to node 20 #95

Merged
merged 5 commits into from
Jan 31, 2024
Merged

Conversation

alessio-perugini
Copy link
Contributor

GitHub will deprecate the node runtime soon. ( https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/)
We're bumping the node version to 20.
After merging this, must follow a bump of the major version of this action.

@alessio-perugini alessio-perugini linked an issue Jan 25, 2024 that may be closed by this pull request
3 tasks
@alessio-perugini alessio-perugini force-pushed the 94-node-16-is-being-deprecated branch from e2542b3 to 05078d2 Compare January 25, 2024 18:05
@alessio-perugini alessio-perugini force-pushed the 94-node-16-is-being-deprecated branch from 16f5bfa to 7a943ee Compare January 25, 2024 18:31
@alessio-perugini alessio-perugini self-assigned this Jan 25, 2024
@alessio-perugini alessio-perugini added type: enhancement Proposed improvement topic: infrastructure Related to project infrastructure topic: code Related to content of the project itself labels Jan 25, 2024
@alessio-perugini alessio-perugini marked this pull request as ready for review January 26, 2024 11:43
.github/workflows/check-npm-task.yml Outdated Show resolved Hide resolved
@alessio-perugini alessio-perugini force-pushed the 94-node-16-is-being-deprecated branch from 7a943ee to c589509 Compare January 26, 2024 13:18
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Alessio!

@alessio-perugini alessio-perugini merged commit c65c819 into master Jan 31, 2024
44 checks passed
@alessio-perugini alessio-perugini deleted the 94-node-16-is-being-deprecated branch January 31, 2024 16:04
@kayabaNerve
Copy link

The CI on the commit merging this appears to have failed, despite the CI here passing.

https://github.com/arduino/setup-protoc/actions/runs/7728930562/job/21070931021

Is any context/insight available on this?

@per1234
Copy link
Contributor

per1234 commented Jan 31, 2024

@kayabaNerve the failure was caused by an external change to the package.json schema that was made between the time of the CI run for this PR and when the PR was merged.

The cause of the workflow run failure was only a defect in the project's CI system, not in the content of the project. So the workflow run failure it is nothing for users of the action to be concerned about.

I submitted a fix with details about the problem here: #96

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself topic: infrastructure Related to project infrastructure type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Node.js 16 is being deprecated for actions
4 participants