Default softWrap #143
Merged
Default softWrap #143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added default softWrap setting
A new installation will enable `softWrap` regardless of user global settings (as in language-gfm). This can be overridden in the packages settings or user config file.
yudai-nkt
requested changes
Aug 20, 2017
CHANGELOG.md
Outdated
| @@ -1,5 +1,10 @@ | |||
| # Changelog | |||
|
|
|||
| ## 1.1.2 | |||
There was a problem hiding this comment.
Remove this line. I don't think this is a patch release. Version number should be written just before a new release.
|
Also, please resolve conflicts. Requesting contributors to update CHANGELOG.md tends to cause a merge conflict. Should we stop this? |
|
Note: Fix #18. |
See if adding the new stuff here works to resolve conflicts
|
It seems that changing CHANGELOG.md after someone forks this package leads to the conflicts when they try and merge again. I don't know the best way to deal with it, but fixing the conflict amounts to deleting the 'conflict syntax' that git adds, so that both your lines and the conflicting lines get added. |
yudai-nkt
approved these changes
Aug 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's the pull. I only enabled it when the
text.tex.latexgrammar is used, so it should work for all normal LaTeX files.It should not set softwrapping to true in the log or bib files, as I believe them to be closer to a structured programming setup, where personal preference may go either way. If you want this changed (for consistency) I'll do it.