Skip to content

Create ISSUE_TEMPLATE.md #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 12, 2017
Merged

Create ISSUE_TEMPLATE.md #156

merged 3 commits into from
Dec 12, 2017

Conversation

Aerijo
Copy link
Collaborator

@Aerijo Aerijo commented Nov 28, 2017

This will provide a template for all new issue submissions, guiding people on how to make new submissions as informative as possible in the first post. No more asking how to reproduce the issue: they will know to have an example ready for anyone to copy and paste to immediately work with.

I put in the first line to feel more welcoming, but I'm open to any suggestions or changes (to any of it).

This helps make new submissions as informative as possible in the first post. No more asking how to reproduce the issue.
@Aerijo Aerijo added the feature label Nov 28, 2017
@Aerijo Aerijo requested a review from yudai-nkt November 28, 2017 07:34
This is in response to new issue where the pasted text was not backticked, so `\(` appeared as `(`
Copy link
Collaborator

@yudai-nkt yudai-nkt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR, this is something I've been wanted! I left a several comment, but they are just comments. Also I prefer the file name to be uppercased to move the issue template upward in the web browser.

<!--
Thanks for notifying us of a new issue!

Before you submit, please make sure you do the following:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these instructions can be a TODO list using a task list rather than a comment (comment cannot be seen in preview section). Good example I know would be a template for PRs in sindresorhus/atom-editorconfig.

<!--
Thanks for notifying us of a new issue!

Before you submit, please make sure you do the following:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"please make sure you have done the following" sounds more natural to me, but I'm not sure if it really is (I'm not a native English speaker :-)).

@Aerijo
Copy link
Collaborator Author

Aerijo commented Dec 11, 2017

Changed the tense, added the prerequisites section, and renamed file. Only using one checkbox to make it easier to use. (I get annoyed just having to delete a space and then put an X in one box, let alone several).

@yudai-nkt
Copy link
Collaborator

You actually don't need to replace a whitespace with an x, but can check each item using a mouse like this:

mouse

@Aerijo
Copy link
Collaborator Author

Aerijo commented Dec 11, 2017

Really? I always fill it out in the text, so I've never tried clicking it when viewing the preview.

@Aerijo
Copy link
Collaborator Author

Aerijo commented Dec 11, 2017

Besides, if they were going to be selective about which steps thay do, they'll probably still tick all the boxes regardless. I know I do that with some things (like the run in safe mode requirement; it probably won't change anything, unless you have a wacky setup).

@yudai-nkt
Copy link
Collaborator

it probably won't change anything, unless you have a wacky setup

This may be true, but issue reporters should follow the instruction as long as the issue template tells them to do so don't they?

@yudai-nkt yudai-nkt changed the title Create issue_template.md Create ISSUE_TEMPLATE.md Dec 12, 2017
@Aerijo
Copy link
Collaborator Author

Aerijo commented Dec 12, 2017

Yeah, they should. I guess my position is that one box is just as good, or better, than multiple boxes. This is how it is on the https://github.com/atom/atom repository.

Having said that, I will change it to multiple boxes if you prefer. It's not the biggest difference in the world, and I like to follow what others want for this package, while trying out my ideas on my own packages.

@yudai-nkt yudai-nkt merged commit 8b3c6e3 into master Dec 12, 2017
@yudai-nkt
Copy link
Collaborator

Uh, I didn't mean to force multiple boxes and merged this only a few seconds after your reply. I just wanted to confirm the intention of the quoted text.

Thanks again for this PR (I hope we don't see MWEs posted as an image anymore lol)!

@Aerijo
Copy link
Collaborator Author

Aerijo commented Dec 12, 2017

@yudai-nkt While, I'm at it, I think I'll make a PR template as well. I had to tell the guy in #160 to update the changelog as well, so giving contributors a checklist would be helpful to everyone.

On a side note, as I say in the PR the proposed change closely resembles the existing patterns for citations, so I don't see any problem there. I'm just not sure how widely used the glossaries package is.

@Aerijo Aerijo deleted the Aerijo-issue_template branch December 12, 2017 12:07
@yudai-nkt yudai-nkt mentioned this pull request Dec 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants