Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comment env support #166

Merged
merged 2 commits into from
Jan 18, 2018
Merged

Add comment env support #166

merged 2 commits into from
Jan 18, 2018

Conversation

Aerijo
Copy link
Collaborator

@Aerijo Aerijo commented Dec 22, 2017

Description of the Change

Adds support for the comment environment.

Alternate Designs

The current design is based almost entirely off the generic environment pattern, just made specific to comments.

The interior scope is consistent with the textmate manual, as it specifies comment.block as a possible scope.

Benefits

The fairly common (and unambiguous) comment environment will have it's contents correctly scoped as comments, ensuring they appear consistent with other comments and the contents do not interfere with other syntax highlighting.

Possible Drawbacks

I am getting a bug due to 'name': 'meta.function.environment.comment.latex' where the begin and end commands are shown as italic (when using a theme that puts comments in italics; tested with one dark and solarized dark). This is specifically caused by the comment term, and removing it or changing it fixes the issue.

However, this should be a syntax package issue and is not our concern. The pattern should remain with the meta scope, to keep it consistent with other environment patterns.

Applicable Issues

#165

@Aerijo Aerijo changed the title Aerijo env comment Add comment env support Dec 23, 2017
@Aerijo
Copy link
Collaborator Author

Aerijo commented Jan 18, 2018

PR is straightforward enough, matches the preexisting format, and the scope is explicitly given in the textmate documentation. Merging.

@Aerijo Aerijo merged commit 079f2b4 into master Jan 18, 2018
@Aerijo Aerijo deleted the Aerijo-env-comment branch September 23, 2018 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant