Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add doctrine/dbal 3.0 support #1226

Merged
merged 5 commits into from
Nov 1, 2021
Merged

Add doctrine/dbal 3.0 support #1226

merged 5 commits into from
Nov 1, 2021

Conversation

ifox
Copy link
Member

@ifox ifox commented Oct 30, 2021

Description

Because this migration uses the ->change() helper from Laravel, Twill needs this dependency. In Twill 3.0 the migrations will be cleaned up to avoid this need, but for now we need to add support for installing doctrine/dbal 3+ in host applications.

Related Issues

Fixes #818

@ifox ifox requested a review from pboivin November 1, 2021 15:38
pboivin
pboivin approved these changes Nov 1, 2021
View reviewed changes
Copy link
Contributor

@pboivin pboivin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I agree that Twill 3.x is a good opportunity to remove this.

Out of curiosity, I took a peak at the Actions tab to see if the change to the test matrix had any impact on the total run time. It doesn't :)

@ifox ifox merged commit 870c482 into 2.x Nov 1, 2021
@ifox ifox deleted the fix/818 branch November 7, 2021 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pboivin pboivin pboivin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

doctrine/dbal ^3.0 is not supported
2 participants
@ifox @pboivin