Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix join() syntax #418

Merged
merged 1 commit into from
Oct 17, 2019
Merged

Fix join() syntax #418

merged 1 commit into from
Oct 17, 2019

Conversation

antonioribeiro
Copy link
Member

Tests are already helping to find some bugs...

join() parameters now follow the same of explode(), glue comes first.

You can see the issue, which would appear only in PHP 7.4, here:

https://3v4l.org/ovuuh

image

@ifox ifox merged commit 57fbdaf into area17:1.2 Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants