Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added an extra prop to repeater field to override the name #528

Merged
merged 1 commit into from
Feb 8, 2020
Merged

Added an extra prop to repeater field to override the name #528

merged 1 commit into from
Feb 8, 2020

Conversation

yanhao-li
Copy link

Added an extra prop name to repeater field used for overriding the repeater name.

@daun
Copy link
Contributor

daun commented Feb 6, 2020

@yanhao-li Just curious, what's the use case for that?

@yanhao-li
Copy link
Author

Hi @philippdaun,
Thanks for rasing this up, as I realize my PR description do miss a lot of details/background.

One of my projects requires two or more same repeater on the form but serves for different purposes. Currently, I have to duplicate the repeater setting in config/twill.php to achieve this, which is a little bit redundant, so the extra name prop is served for that purpose.

I'm also thinking about adding more props to the repeater to override the settings. (like max, component, trigger), all those props shall fallback to the setting, but will make the field more customizable.

@daun
Copy link
Contributor

daun commented Feb 6, 2020

@yanhao-li Makes perfect sense!

@ifox ifox merged commit 0ce0c4c into area17:1.2 Feb 8, 2020
antonioribeiro pushed a commit to antonioribeiro/twill that referenced this pull request Feb 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants