Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to iojs-2.5.0 and no more patching node-gyp... Edit: failed #21

Merged
merged 1 commit into from
Jul 30, 2015
Merged

Upgrade to iojs-2.5.0 and no more patching node-gyp... Edit: failed #21

merged 1 commit into from
Jul 30, 2015

Conversation

hmalphettes
Copy link
Collaborator

This is not our usual upgrade to the latest iojs: iojs-2.50 and npm-2.13.2.

We have to remove entirely the patching of node-gyp.
It is no longer necessary: nodejs/node#990 is merged and takes care of downloading the sources from the proper URL.

Yay!

Celebrating with a Party Pull Request!

ヽ(⌐■_■)ノ♪♬

@hmalphettes
Upgrade to iojs-2.5.0 and npm-2.13.2. No patch
465ad87 
Since iojs-2.5.0 a new version of node-gyp is in place
and it does not require us to patch it anymore.
The newer version of node-gyp reads the URL of the downloads
of the iojs headers on the process object:
nodejs/node#990
hmalphettes added a commit that referenced this pull request Jul 30, 2015
@hmalphettes
Merge pull request #21 from hmalphettes/master
29f0907 
Upgrade to iojs-2.5.0 and no more patching node-gyp
@hmalphettes hmalphettes merged commit 29f0907 into aredridel:master Jul 30, 2015
@hmalphettes
Copy link
Collaborator Author

@bcomnes @aredridel Probably a good time to revisit Homebrew/legacy-homebrew#36369

@rstacruz
Copy link
Collaborator

👍

@rstacruz rstacruz mentioned this pull request Jul 30, 2015
Closed
2 tasks
@aredridel
Copy link
Owner

dances! :shipit:

@othiym23
Copy link

I'm not sure why people think the landing of nodejs/node#990 implies that the npm team is not landing floating patches with each new version of npm, but that isn't the case. Unless and until the changes related to process.release are landed and a new version of node-gyp is published that takes advantage of it, we continue to have to cherry-pick io.js commits, as per https://github.com/npm/npm/wiki/Release-Process#for-iojs. Sorry!

@othiym23
Copy link

To be clear, an unpatched npm installed outside of the io.js installer will still not be able to find its patches, and the use of either a patched npm or pangyp is still required unless you're using the npm distributed with io.js.

@aredridel
Copy link
Owner

Well shucks!

@aredridel aredridel mentioned this pull request Jul 30, 2015
Merged
@bcomnes
Copy link
Collaborator

bcomnes commented Jul 30, 2015

🎉 for progress! Thanks for the heads up.

@hmalphettes
Copy link
Collaborator Author

@othiym23 Thanks for the clarification.
I declared victory too early.
Sorry everyone for the false hopes.

@hmalphettes hmalphettes changed the title Upgrade to iojs-2.5.0 and no more patching node-gyp Upgrade to iojs-2.5.0 and no more patching node-gyp... Edit: failed Jul 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hmalphettes @rstacruz @aredridel @othiym23 @bcomnes