Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed resizing ring stack, segmentation fault and exit logging threads #270

Merged
merged 2 commits into from
Dec 2, 2023

Conversation

aregtech
Copy link
Owner

@aregtech aregtech commented Dec 1, 2023

Made multiple fixes of bugs:

  1. Fixed logic of reading configuration and resizing ring stack of the messages in the NetLogger;
  2. Fixed segmentation fault issue happening after reserving space in the ring stack.
  3. Fixed issue of exiting read and receive threads when run NetLogger. After closing the threads where not ending.
  4. Fixed issue of delaying exit threads.
  5. Made changes in the layouts to be able to log cookies and module name.

…fixed bug of exiting net logger and threads.
@aregtech aregtech added bug Something isn't working enhancement New feature or request optimization bugfix labels Dec 1, 2023
@aregtech aregtech requested a review from vukihub December 1, 2023 19:50
@aregtech aregtech self-assigned this Dec 1, 2023
@aregtech aregtech linked an issue Dec 1, 2023 that may be closed by this pull request
Copy link
Collaborator

@vukihub vukihub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some slight changes are requested.

framework/areg/trace/private/NetTcpLogger.cpp Outdated Show resolved Hide resolved
framework/areg/trace/private/TraceManager.cpp Show resolved Hide resolved
Copy link
Collaborator

@vukihub vukihub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@aregtech aregtech merged commit 58efe3d into master Dec 2, 2023
46 checks passed
@aregtech aregtech deleted the bugfix/269-netlog-message-queue-initialization branch December 5, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working bugfix enhancement New feature or request optimization
Projects
Status: Reviewed
Development

Successfully merging this pull request may close these issues.

NetLog message queue initialization
2 participants