-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Queue.subscribe! #20
Queue.subscribe! #20
Conversation
Thanks for this implementation! I will look at it more closely later tonight |
You can hold this PR until further notice, I've found some shortcomings I want to fix. |
Ok @arempe93, happy with this now. Added support for multiple routes with them same key. Basically |
Looks pretty good to me - only question is why call |
Reason for that is that if there are messages in the queue they will be delivered when a consumer subscribes. |
Ok - that makes sense. For some reason I didn't think of the case that there could be messages entered into the queue before a subscription happens. |
Sweet, when are u planning next release? |
Probably when I have time after work today. I don't think there's anything else in progress right now |
In-memory implementation of http://reference.rubybunny.info/Bunny/Queue.html#subscribe-instance_method