Use ocamlformat #66
Use ocamlformat #66
Conversation
brendanlong
force-pushed
the
ocamlformat
branch
from
9072a77 to
e9e35f4
Compare
brendanlong
force-pushed
the
ocamlformat
branch
from
e9e35f4 to
5e4d424
Compare
| @@ -1 +1,2 @@ | |||
| (lang dune 1.1) | |||
There was a problem hiding this comment.
we'd need to bump the dune language version to 1.7 since that's the first releast with fmt support.
reference: ocaml/opam-repository#15560 (comment)
There was a problem hiding this comment.
I'm trying to keep the opam deps are wide as possible so we don't limit how people can use this. For dune build @fmt, people don't need to run that at release anyway. I wish there was a way to specify particular deps for dev but not opam :\
There was a problem hiding this comment.
I know dune doesn't fail at the moment, but it could in theory fail if it stars a check for what language version is used vs what language features we use. :\
Its unfortunate that the formatter can't be run via dune without this stanza in the dune-project file
| @@ -1,3 +1,7 @@ | |||
| #!/usr/bin/env ocaml | |||
|
|
|||
There was a problem hiding this comment.
we can probably get rid of this file, since we'd need to use dune-release instead of topkg for publishing new releases
There was a problem hiding this comment.
I'm going to leave this since I don't know what it does. We can remove it in another PR if it's unnecessary.
|
I'll wait to do this until after #62 |
brendanlong
force-pushed
the
ocamlformat
branch
from
5e4d424 to
4b505cb
Compare
No description provided.