fix: not formated topic in webxr sys

There is a race condition here somehow, ready in arena sets topicParams but apparently webxr-env sys loads before that fires.
arenaxr · Nov 19, 2024 · 5027d0d · 5027d0d
1 parent 0d604de
commit 5027d0d
Showing 1 changed file with 15 additions and 5 deletions.
diff --git a/src/systems/webxr/webxr-env-publisher.js b/src/systems/webxr/webxr-env-publisher.js
@@ -24,16 +24,14 @@ AFRAME.registerSystem('xr-env-publisher', {
             useRecords: false,
             useFloat32: true,
         });
-
-        this.pubTopic = TOPICS.PUBLISH.SCENE_ENV_PRIVATE.formatStr(ARENA.topicParams);
     },
     async webXRSessionStarted(xrSession) {
         if (xrSession === undefined) return;
         xrSession.requestAnimationFrame(this.onRAF);
     },
     async onRAF(_time, frame) {
         const {
-            data: { publishMeshes, publishPlanes, publishTopicBase, onlyGlobalMesh },
+            data: { publishMeshes, publishPlanes, onlyGlobalMesh },
         } = this;
         if (
             // No mesh or plane support
@@ -60,7 +58,13 @@ AFRAME.registerSystem('xr-env-publisher', {
                         meshPose: Object.values(frame.getPose(mesh.meshSpace, xrRefSpace).transform.matrix),
                     });
                     ARENA.debugXR(`Packing and publishing ${mesh.semanticLabel}`);
-                    ARENA.Mqtt.publish(this.pubTopic, msg, undefined, undefined, true);
+                    ARENA.Mqtt.publish(
+                        TOPICS.PUBLISH.SCENE_ENV_PRIVATE.formatStr(ARENA.topicParams),
+                        msg,
+                        undefined,
+                        undefined,
+                        true
+                    );
                 });
             }
             if (publishPlanes) {
@@ -73,7 +77,13 @@ AFRAME.registerSystem('xr-env-publisher', {
                         planePose: frame.getPose(plane.planeSpace, xrRefSpace).transform.matrix,
                     });
                     ARENA.debugXR(`Packing and publishing ${plane.semanticLabel}`);
-                    ARENA.Mqtt.publish(this.pubTopic, msg, undefined, undefined, true);
+                    ARENA.Mqtt.publish(
+                        TOPICS.PUBLISH.SCENE_ENV_PRIVATE.formatStr(ARENA.topicParams),
+                        msg,
+                        undefined,
+                        undefined,
+                        true
+                    );
                 });
             }
         }