fix: handle persistent anchor setting failure

We remove oldest anchor if the set is full
arenaxr · Dec 8, 2023 · 7f3cad4 · 7f3cad4
1 parent ceb4e4a
commit 7f3cad4
Showing 1 changed file with 17 additions and 4 deletions.
diff --git a/src/systems/armarker/armarker.js b/src/systems/armarker/armarker.js
@@ -22,6 +22,8 @@ import CVWorkerMsgs from './worker-msgs';
 import { ARENA_EVENTS } from '../../constants';
 import { ARENAUtils } from '../../utils';
 
+const MAX_PERSISTENT_ANCHORS = 7;
+
 /**
  * ARMarker System. Supports ARMarkers in a scene.
  * @module armarker-system
@@ -517,10 +519,21 @@ AFRAME.registerSystem('armarker', {
                     // Delete the old anchor
                     this.webXRSession.deletePersistentAnchor(oldPersistAnchor);
                 }
-                anchor.requestPersistentHandle().then((handle) => {
-                    // Save the new one
-                    window.localStorage.setItem('originAnchor', handle);
-                });
+                // Check how many anchors there are, Quest has a low limit currently
+                if (this.webXRSession.persistentAnchors.size >= MAX_PERSISTENT_ANCHORS) {
+                    // Delete the oldest anchor
+                    const oldestAnchor = this.webXRSession.persistentAnchors.values().next().value;
+                    this.webXRSession.deletePersistentAnchor(oldestAnchor);
+                }
+                anchor
+                    .requestPersistentHandle()
+                    .then((handle) => {
+                        // Save the new one
+                        window.localStorage.setItem('originAnchor', handle);
+                    })
+                    .catch((err) => {
+                        console.error('Could not persist anchor', err);
+                    });
             } else if (this.originAnchor) {
                 this.originAnchor.delete();
             }